Richard Benjamin’s My Favorite Year (1982) makes nice use of the “Watching yourself” trope. The movie, set in 1954, was produced by Mel Brooks and was loosely based on his experience as a writer on the Sid Caesar TV comedy series Your Show of Shows, where the swashbuckling movie star Errol Flynn was once the guest star. Evidently, Flynn’s appearance on the show was uneventful. That is not the case with the Flynn-ish figure in My Favorite Year, Alan Swann (Peter O’Toole), who is usually drunk, rarely on time, and beset by a bad case of stage fright.
In this scene, the writing staff assembles to watch some clips from Swann movies. That staff consists of Sy (Bill Macy, loosely based on Mel Tolkin); Herb (Basil Hoffman; l.b.o. Neil Simon); Alice (Anne De Salvo; Lucille Kaillen); and the “My” of the title, young Benjy Stone (Mark Linn-Baker; Brooks himself).
What they see comes from two actual Peter O’Toole movies, Lord Jim (1968) and Great Catherine (1965). Sy isn’t a fan of the performances: “That’s not acting–that’s kissing and jumping and drinking and humping. I don’t know why we’re wasting out eyesight on this crap.” It’s reminiscent of the way Bette Davis’s early work was dumped on in What Ever Happened to Baby Jane? and, as with Davis, it’s proof that O’Toole was a good sport.
Later, the star of the show, King Kaiser (Joseph Bologna; not so loosely based on Caesar) and the producer, Leo (Adolph Green), join the writers to watch another Swann movie. What they see this time isn’t a real O’Toole film but footage expressly created for My Favorite Year: a convincing (down to the Technicolor, music, and editing) homage to Flynn’s The Adventures of Robin Hood (1939).
Later, Benjy watches more of the movie, which is called Defender of the Crown, with a co-worker he’s got a crush on, K.C. (Jessica Harper). They’re both so transfixed by it that it ends up sealing their romance. I guess Alan Swann isn’t such a terrible actor after all.